Skip to content

Add svg ColorMapper to svg loader #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

Add svg ColorMapper to svg loader #680

merged 4 commits into from
May 9, 2025

Conversation

sysint64
Copy link
Contributor

@sysint64 sysint64 commented Apr 3, 2025 •
edited
Loading

What does this change?

Add possibility to specify color mapper for svg.

Fixes #679 🎯

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525
Copy link
Member

AlexV525 commented Apr 15, 2025 •
edited
Loading

We've landed changes that updated most of the generated files. You might need to rebase and regenerate them using the tool provided by #682.

@sysint64
Copy link
Contributor Author

@AlexV525 Updated

@sysint64
Copy link
Contributor Author

@AlexV525 Is there some issue on my side or is it CI? When I run the following command locally: melos run coverage it works just fine.

@AlexV525
Copy link
Member

AlexV525 commented Apr 27, 2025 •
edited
Loading

@AlexV525 Is there some issue on my side or is it CI? When I run the following command locally: melos run coverage it works just fine.

It is affected by the upstream regardless of your changes. However merging this requires all tests to be passed, I'll look into it later.

@codecov Codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (b9988c1) to head (80835a5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          22       22           
  Lines         840      840           
=======================================
  Hits          813      813           
  Misses         27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexV525
Copy link
Member

AlexV525 commented May 9, 2025

Looks like it was flaky rather than an actual issue.

@AlexV525 AlexV525 merged commit 5b7b60e into FlutterGen:main May 9, 2025
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

@wasabeef wasabeef Awaiting requested review from wasabeef wasabeef is a code owner

@lcdsmao lcdsmao Awaiting requested review from lcdsmao lcdsmao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Add svg color mapper
2 participants
@sysint64 @AlexV525